Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustup 20140508 #5

Closed
wants to merge 7 commits into from
Closed

Rustup 20140508 #5

wants to merge 7 commits into from

Conversation

@larsbergstrom
Copy link

larsbergstrom commented May 14, 2014

r? @SimonSapin

Is this what you'd expect? (merge into master)

@metajack
Copy link

metajack commented May 14, 2014

Why are we merging into master here? Should our master always be a fast forward away from upstream master?

@larsbergstrom
Copy link
Author

larsbergstrom commented May 14, 2014

Yes, according to conversations with @SimonSapin on IRC, we should always just be pulling from their master and shouldn't have any local changes. If we did, then we should probably fork a servo branch like our other forks of upstream projects.

@SimonSapin
Copy link
Member

SimonSapin commented May 15, 2014

908f4f8 is the only non-merge commit that we have and not upstream.

@SimonSapin
Copy link
Member

SimonSapin commented May 15, 2014

We should decide on a single workflow we want (it terms of branches, merges and review) for all Servo submodules that have an upstream and stick to it.

I believe there is no use in maintaining a master branch that’s identical to and kept up to date with upstream/master, since that is obviously redundant with upstream/master. To keep things simple, we could have mozilla-servo/master be our only long-lived branch, include any Servo-specific changes, and occasionally merge upstream/master into it.

@metajack metajack closed this May 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.