Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement precise mouse wheel handling and pinch-to-zoom on Mac. #19

Merged
merged 1 commit into from Jun 11, 2013

Conversation

@pcwalton
Copy link
Contributor

pcwalton commented Jun 9, 2013

r? @brson

@metajack

This comment has been minimized.

Copy link

metajack commented on c671213 Jun 10, 2013

Why is the scroll wheel callback doing double duty here? What is the 10k multiplier for for the magnification?

This comment has been minimized.

Copy link
Owner Author

pcwalton replied Jun 11, 2013

The scroll wheel callback is used because I didn't want to extend the de facto GLUT API with more methods, and pinch-to-zoom is "sort of" like a scroll wheel. The 10,000 multiplier is just to pack a decent supply of precision from a float into an int.

All of this is a terrible hack extending GLUT beyond what it was meant to do.

metajack added a commit that referenced this pull request Jun 11, 2013
Implement precise mouse wheel handling and pinch-to-zoom on Mac.
@metajack metajack merged commit 04f51f0 into servo:master Jun 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.