Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support android build #27

Closed
wants to merge 1 commit into from
Closed

support android build #27

wants to merge 1 commit into from

Conversation

@aydinkim
Copy link
Contributor

aydinkim commented Aug 7, 2013

Support android build
This commit does not affect to each submodule's original standalone build system.
Added android freeglut binder.

@@ -64,6 +64,8 @@ static WINDOW_HEIGHT: GLenum = 103;
pub static HAVE_PRECISE_MOUSE_WHEEL: bool = false;
#[cfg(target_os="macos")]
pub static HAVE_PRECISE_MOUSE_WHEEL: bool = true;
#[cfg(target_os="android")]

This comment has been minimized.

Copy link
@metajack

metajack Aug 7, 2013

Contributor

Just add this cfg attribute to the linux section previously.

This comment has been minimized.

Copy link
@aydinkim

aydinkim Aug 8, 2013

Author Contributor

Ok, we will integrate linux and android block.

@metajack
Copy link
Contributor

metajack commented Aug 7, 2013

I do not understand what android-glue is doing. Can you explain what is going on here?

@ILyoan
Copy link
Contributor

ILyoan commented Aug 8, 2013

This version of servo-android port is using libfreeglut 3.0 which supports android.(I think we should transfer to glfw right?)
Unfortunately, the libfreeglut has android entry and main event loop in it and thus it should be statically linked to user application so that android system could find android main entry.
The problem in this situcation is that the servo engine could not link libfreeglut directly because the servo android application(libfreeglut statcally linked with it) dynamically links servo engine(libservo.so).
The purpose of android-glue is to provide servo engine with a path to call libfreeglut functions. Servo app would register callbacks for each glut function before starts servo engine. and then, when the callback was invoked by servo engline, the callback function would actually call the mapped glut function.

This was the best option for me when I was working on servo android.
If you have better soultion or advice, it would be very appreciated.

@aydinkim
Copy link
Contributor Author

aydinkim commented Aug 13, 2013

Adapted another PR. this commit is invalid. Close.

@aydinkim aydinkim closed this Aug 13, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.