Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upupdate for language changes #29
Merged
+72
−111
Conversation
glut.rs
Outdated
| @@ -80,7 +79,7 @@ pub fn init() { | |||
| unsafe { | |||
| let argc = 0 as c_int; | |||
| let glut = ~"glut"; | |||
| let command = glut.as_bytes_with_null(); | |||
| let command = glut.as_bytes(); | |||
This comment has been minimized.
This comment has been minimized.
metajack
Aug 21, 2013
Contributor
as_bytes() does not include the null terminator. This seems like a problem.
This comment has been minimized.
This comment has been minimized.
aydinkim
Aug 21, 2013
Author
Contributor
I couldn't find out the same rust embedded function of that, yet.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@metajack I had fixed and submitted a PR again. |
|
Looks good. I have only minor suggestions. I'll r+ once you address these. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aydinkim commentedAug 21, 2013
Since language update.