Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hb_ot_* bindings. #102

Merged

Conversation

@waywardmonkeys
Copy link
Collaborator

waywardmonkeys commented Jan 16, 2018

hb-ot.h isn't included by hb.h, so bindings for the OpenType APIs weren't being generated. This corrects that.


This change is Reviewable

@jdm
Copy link
Member

jdm commented Jan 16, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Jan 16, 2018

📌 Commit 7a0130d has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Jan 16, 2018

Testing commit 7a0130d with merge 479c42d...

bors-servo added a commit that referenced this pull request Jan 16, 2018
Add hb_ot_* bindings.

`hb-ot.h` isn't included by `hb.h`, so bindings for the OpenType APIs weren't being generated. This corrects that.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-harfbuzz/102)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 17, 2018

💥 Test timed out

@jdm
Copy link
Member

jdm commented Jan 17, 2018

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Jan 17, 2018

Testing commit 7a0130d with merge bc5be9f...

bors-servo added a commit that referenced this pull request Jan 17, 2018
Add hb_ot_* bindings.

`hb-ot.h` isn't included by `hb.h`, so bindings for the OpenType APIs weren't being generated. This corrects that.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-harfbuzz/102)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 17, 2018

☀️ Test successful - status-travis
Approved by: jdm
Pushing bc5be9f to master...

@bors-servo bors-servo merged commit 7a0130d into servo:master Jan 17, 2018
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@waywardmonkeys waywardmonkeys deleted the waywardmonkeys:add-missing-opentype-bindings branch Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.