Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd wrapper for hb_blob_t #109
Merged
Conversation
mbrubeck
force-pushed the
mbrubeck:blob
branch
2 times, most recently
from
b9b92d3
to
f2a7583
harfbuzz/src/blob.rs
Outdated
| } | ||
|
|
||
| /// Returns true if the blob is immutable. | ||
| pub fn is_immutable(&mut self) { |
This comment has been minimized.
This comment has been minimized.
waywardmonkeys
May 17, 2018
Collaborator
This looks like a copy paste error ... it is the same as the above function.
This comment has been minimized.
This comment has been minimized.
| /// Returns the size of the blob in bytes. | ||
| pub fn len(&self) -> usize { | ||
| unsafe { sys::hb_blob_get_length(self.raw) as usize } | ||
| } |
This comment has been minimized.
This comment has been minimized.
waywardmonkeys
May 17, 2018
Collaborator
Suspect that with a len function, clippy will warm if there isn’t an is_empty function.
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
May 17, 2018
Add wrapper for hb_blob_t <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-harfbuzz/109) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mbrubeck commentedMay 16, 2018
•
edited by larsbergstrom
This change is