Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upWIP: Basic support for text shaping #112
Closed
+191
−1
Conversation
| } | ||
|
|
||
| impl<'a> Glyph<'a> { | ||
| /// Either a Unicode code point (before shaping) or a glyph ID (after shaping) |
This comment has been minimized.
This comment has been minimized.
waywardmonkeys
Jun 22, 2018
Collaborator
Could we have 2 separate structs for this and only have the right thing at the right time?
This comment has been minimized.
This comment has been minimized.
waywardmonkeys
Jun 22, 2018
Collaborator
I have wondered if that extends all the way to consuming a Buffer and having a ShapedBuffer...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mbrubeck commentedMay 17, 2018
•
edited by larsbergstrom
This adds very minimal support for using
hb_shapethrough the safe Rust API. It's not very complete, and I welcome any feedback on the design.This change is