Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove Clone impls for Buffer and Blob #113
Merged
Conversation
Allowing these types to be cloned makes it impossible to provide safe borrowed access to their contents, because one handle could mutate or clear the contents while they are borrowed through another handle. Safe Rust code that needs to have multiple pointers to a single buffer or blob should use Rc/Arc or &T pointers instead.
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
May 19, 2018
Remove Clone impls for Buffer and Blob Reverts #111. I realized that allowing these types to be cloned makes it impossible to provide safe borrowed access to their contents, because one handle could mutate or clear the contents while they are borrowed through another handle. Rust code that needs multiple pointers to a single buffer or blob should use Rc/Arc or `&T` instead. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-harfbuzz/113) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mbrubeck commentedMay 17, 2018
•
edited by larsbergstrom
Reverts #111.
I realized that allowing these types to be cloned makes it impossible to provide safe borrowed access to their contents, because one handle could mutate or clear the contents while they are borrowed through another handle.
Rust code that needs multiple pointers to a single buffer or blob should use Rc/Arc or
&Tinstead.This change is