Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upBuild with clang on ARM/Android #119
Merged
Conversation
|
r? @jdm |
|
Any chance that just using the cmake build for |
|
It would be nice to move to that, but I would prefer not to make these changes wait on investigating it. We're already juggling a number of dependencies and toolchain changes as part of the upstream Servo change that requires these ones. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 3, 2018
Build with clang on ARM/Android Makes it possible to build with clang for Android. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-harfbuzz/119) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asajeffrey commentedAug 3, 2018
•
edited by larsbergstrom
Makes it possible to build with clang for Android.
This change is