Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate to harfbuzz 1.9.0 #120
Merged
+13,360
−6,789
Conversation
|
This is a breaking change. |
|
@nox: Yes ... in that some things got to be I have another couple of commits queued up to bump the version to |
|
Why not put them in the same PR? |
|
Added 2 of the commits here for now. The other one is about doc comments and I have to work on it more and probably do some of it upstream first. |
|
Any thoughts on this apart from it being a breaking change? |
|
Looks good to me. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 20, 2018
Update to harfbuzz 1.9.0 <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-harfbuzz/120) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
waywardmonkeys commentedSep 17, 2018
•
edited by larsbergstrom
This change is