Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upfixup compilation of libharfbuzz on macos #128
Merged
Conversation
The library is missing coretext features on macos; this manifests in the travis build for wezterm here: https://travis-ci.org/wez/wezterm/jobs/497309625 ``` "_hb_coretext_font_create", referenced from: wezterm::font::hbwrap::Font::new_coretext::hd071aafeac2e8295 in wezterm-0dd706f6ee97bf14.10pwsdaw58utpw8o.rcgu.o ld: symbol(s) not found for architecture x86_64 clang: error: linker command failed with exit code 1 (use -v to see invocation) ``` Inspecting the output of the build shows that configure is being invoked this way: ``` cd /Users/wez/src/wezterm/target/debug/build/harfbuzz-sys-0ec3b8d6c31c3064/out && /Users/wez/.cargo/registry/src/github.com-1ecc6299db9ec823/harfbu zz-sys-0.3.0/harfbuzz/configure --prefix=/Users/wez/src/wezterm/target/debug/build/harfbuzz-sys-0ec3b8d6c31c3064/out --host=x86_64-apple-darwin --e nable-static --disable-shared --without-icu --without-freetype --without-glib \ CFLAGS="-fPIC -g" CXXFLAGS="-fPIC -g" CPPFLAGS="" ``` It appears that the logic in `makefile.cargo` isn't effective at detecting macos in either the travis mac environment or on my local macbook (after I uninstalled my locally installed hombrew harfbuzz). This commit changes the invocation to unconditionally ask configure to probe for coretext and enable it if found.
wez
added a commit
to wez/wezterm
that referenced
this pull request
Feb 23, 2019
|
This seems reasonable to me. Anyone else? |
|
Agreed. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 26, 2019
fixup compilation of libharfbuzz on macos The library is missing coretext features on macos; this manifests in the travis build for wezterm here: https://travis-ci.org/wez/wezterm/jobs/497309625 ``` "_hb_coretext_font_create", referenced from: wezterm::font::hbwrap::Font::new_coretext::hd071aafeac2e8295 in wezterm-0dd706f6ee97bf14.10pwsdaw58utpw8o.rcgu.o ld: symbol(s) not found for architecture x86_64 clang: error: linker command failed with exit code 1 (use -v to see invocation) ``` Inspecting the output of the build shows that configure is being invoked this way: ``` cd /Users/wez/src/wezterm/target/debug/build/harfbuzz-sys-0ec3b8d6c31c3064/out && /Users/wez/.cargo/registry/src/github.com-1ecc6299db9ec823/harfbu zz-sys-0.3.0/harfbuzz/configure --prefix=/Users/wez/src/wezterm/target/debug/build/harfbuzz-sys-0ec3b8d6c31c3064/out --host=x86_64-apple-darwin --e nable-static --disable-shared --without-icu --without-freetype --without-glib \ CFLAGS="-fPIC -g" CXXFLAGS="-fPIC -g" CPPFLAGS="" ``` It appears that the logic in `makefile.cargo` isn't effective at detecting macos in either the travis mac environment or on my local macbook (after I uninstalled my locally installed hombrew harfbuzz). This commit changes the invocation to unconditionally ask configure to probe for coretext and enable it if found. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-harfbuzz/128) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
wez commentedFeb 23, 2019
•
edited by larsbergstrom
The library is missing coretext features on macos; this manifests
in the travis build for wezterm here:
https://travis-ci.org/wez/wezterm/jobs/497309625
Inspecting the output of the build shows that configure is being invoked this way:
It appears that the logic in
makefile.cargoisn't effective at detecting macosin either the travis mac environment or on my local macbook (after I uninstalled
my locally installed hombrew harfbuzz).
This commit changes the invocation to unconditionally ask configure to probe for
coretext and enable it if found.
This change is