Skip to content

/ rust-harfbuzz

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS: Add bindings for hb-coretext functions. #133

Merged
merged 1 commit into from Mar 14, 2019
Merged

macOS: Add bindings for hb-coretext functions. #133

merged 1 commit into from Mar 14, 2019

Conversation

@waywardmonkeys
Copy link
Collaborator

waywardmonkeys commented Mar 14, 2019 •
edited by larsbergstrom

This adds a macOS-only dependency upon core_graphics, core_text,
and foreign_types, so that we can interop with the CGFontRef
and CTFontRef values from the existing core_graphics and core_text
bindings.

This change is Reviewable
@waywardmonkeys
macOS: Add bindings for hb-coretext functions.
Loading status checks…
9c17d51 
This adds a macOS-only dependency upon core_graphics, core_text,
and foreign_types, so that we can interop with the CGFontRef
and CTFontRef values from the existing core_graphics and core_text
bindings.
@raphlinus
raphlinus approved these changes Mar 14, 2019
View changes
Copy link
Contributor

raphlinus left a comment

This looks good to me. It's unfortunate that we have to treat the CGFontRef and CTFontRef types differently, and that the former doesn't match core_foundation::core_graphics::CGFontRef, but as discussed on IRC, that seems to be an issue to be fixed in the core_foundation crate. In the meantime, I can see how to use these effectively.
@mbrubeck
Copy link
Contributor

mbrubeck commented Mar 14, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Mar 14, 2019

📌 Commit 9c17d51 has been approved by mbrubeck
bors-servo added a commit that referenced this pull request Mar 14, 2019
@bors-servo
Auto merge of #133 - waywardmonkeys:coretext, r=mbrubeck
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a3425a7 
macOS: Add bindings for hb-coretext functions.

This adds a macOS-only dependency upon core_graphics, core_text,
and foreign_types, so that we can interop with the CGFontRef
and CTFontRef values from the existing core_graphics and core_text
bindings.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-harfbuzz/133)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 14, 2019

⌛ Testing commit 9c17d51 with merge a3425a7...
@bors-servo
Copy link
Contributor

bors-servo commented Mar 14, 2019

☀️ Test successful - checks-travis
Approved by: mbrubeck
Pushing a3425a7 to master...
@bors-servo bors-servo merged commit 9c17d51 into servo:master Mar 14, 2019
3 checks passed
3 checks passed
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@waywardmonkeys waywardmonkeys deleted the waywardmonkeys:coretext branch Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphlinus raphlinus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@waywardmonkeys @mbrubeck @bors-servo @raphlinus
You can’t perform that action at this time.