Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upExclude only test font data #144
Merged
Conversation
|
Agreed. Thanks! |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 8, 2019
Exclude only test font data This is a key part taken from #138 and #142. I'm creating a new PR here for just this since those others have been combined with other, somewhat orthogonal issues. I think it's best to go ahead and merge this and make a release, since this issue is affecting others. I'll continue working on the other issues. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-harfbuzz/144) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
spl commentedApr 8, 2019
•
edited by larsbergstrom
This is a key part taken from #138 and #142. I'm creating a new PR here for just this since those others have been combined with other, somewhat orthogonal issues. I think it's best to go ahead and merge this and make a release, since this issue is affecting others. I'll continue working on the other issues.
This change is