Skip to content

/ rust-harfbuzz

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create test matrix for Travis-CI #146

Merged
merged 1 commit into from Apr 16, 2019
Merged

Create test matrix for Travis-CI #146

merged 1 commit into from Apr 16, 2019
+123 −35

Conversation

@spl
Copy link
Contributor

spl commented Apr 16, 2019 •
edited by larsbergstrom

This change significantly increases the surface area tested on Travis. It includes a few notable changes, namely touch hb-version.* and harfbuzz-sys-test/build.rs, that allow various tests to pass. It also adds cargo test and cargo package.

This change is Reviewable
@spl spl mentioned this pull request Apr 16, 2019
Closed
@spl spl force-pushed the spl:expand-travis branch from aab5113 to af0ba79 Apr 16, 2019
@spl
Create test matrix for Travis-CI
Loading status checks…
28d6219 
* Linux & macOS
* shared and static
* cargo test, cargo package
* makefile.touch
* touch src/hb-version.*
* cache .cargo
@spl spl force-pushed the spl:expand-travis branch from af0ba79 to 28d6219 Apr 16, 2019
@spl
Copy link
Contributor Author

spl commented Apr 16, 2019

I made a couple of force-pushes to fix a few things, which are commented in the .travis.yml. Of note, there is still the issue of sporadic file modifications in cargo package that I was chasing in #142. In this PR, I use cargo package --no-verify to ignore those. So, even though I sweep that issue under the rug, I still think this PR is a net improvement.
@jdm
Copy link
Member

jdm commented Apr 16, 2019

Agreed!
@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2019

📌 Commit 28d6219 has been approved by jdm
bors-servo added a commit that referenced this pull request Apr 16, 2019
@bors-servo
Auto merge of #146 - spl:expand-travis, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6c442b9 
Create test matrix for Travis-CI

This change significantly increases the surface area tested on Travis. It includes a few notable changes, namely `touch hb-version.*` and `harfbuzz-sys-test/build.rs`, that allow various tests to pass. It also adds `cargo test` and `cargo package`.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-harfbuzz/146)
<!-- Reviewable:end -->
@jdm
Copy link
Member

jdm commented Apr 16, 2019

Thanks for all the investigation and CI improvements, by the way!
@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2019

⌛ Testing commit 28d6219 with merge 6c442b9...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 16, 2019

☀️ Test successful - checks-travis
Approved by: jdm
Pushing 6c442b9 to master...
@bors-servo bors-servo merged commit 28d6219 into servo:master Apr 16, 2019
3 checks passed
3 checks passed
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@spl spl deleted the spl:expand-travis branch Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@spl @jdm @bors-servo
You can’t perform that action at this time.