Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAvoid source changes during static build #147
Merged
Conversation
`cargo package` sporadically complains about file modifications outside `OUT_DIR`. See #142 for an experiment with chasing down that issue, which can involve different files changed at different times. The build script is written to build out-of-tree in `OUT_DIR`, but `configure` and/or `make` still modify the source tree. This change involves creating a temporary `BUILD_DIR` in `OUT_DIR`, copying the source files there, building, installing into `OUT_DIR`, and, finally, removing `BUILD_DIR`.
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 17, 2019
Avoid source changes during static build `cargo package` sporadically complains about file modifications outside `OUT_DIR`. See #142 for an experiment with chasing down that issue, which can involve different files changed at different times. The build script is written to build out-of-tree in `OUT_DIR`, but `configure` and/or `make` still modify the source tree. This change involves creating a temporary `BUILD_DIR` in `OUT_DIR`, copying the source files there, building, installing into `OUT_DIR`, and, finally, removing `BUILD_DIR`. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-harfbuzz/147) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
spl commentedApr 17, 2019
•
edited by larsbergstrom
cargo packagesporadically complains about file modifications outsideOUT_DIR. See #142 for an experiment with chasing down that issue, which can involve different files changed at different times.The build script is written to build out-of-tree in
OUT_DIR, butconfigureand/ormakestill modify the source tree.This change involves creating a temporary
BUILD_DIRinOUT_DIR, copying the source files there, building, installing intoOUT_DIR, and, finally, removingBUILD_DIR.This change is