Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDon't print cargo:include= with pkg-config #148
Merged
Conversation
I introduced this in 692048e, but it's the wrong thing to do. When a dependent crate gets the pkg-config include paths in DEP_HARFBUZZ_INCLUDE, it may also need other aspects such as the link paths, but it doesn't know that information is available from pkg-config. So, the dependent crate must assume that, if DEP_HARFBUZZ_INCLUDE is not available, it should use pkg-config.
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 18, 2019
Don't print cargo:include= with pkg-config I introduced this in 692048e, but it's the wrong thing to do. When a dependent crate gets the `pkg-config` include paths in `DEP_HARFBUZZ_INCLUDE`, it may also need other aspects such as the link paths, but it doesn't know that information is available from `pkg-config`. So, the dependent crate must assume that, if `DEP_HARFBUZZ_INCLUDE` is not available, it should use `pkg-config`. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-harfbuzz/148) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
spl commentedApr 18, 2019
•
edited by larsbergstrom
I introduced this in 692048e, but it's the wrong thing to do. When a dependent crate gets the
pkg-configinclude paths inDEP_HARFBUZZ_INCLUDE, it may also need other aspects such as the link paths, but it doesn't know that information is available frompkg-config. So, the dependent crate must assume that, ifDEP_HARFBUZZ_INCLUDEis not available, it should usepkg-config.This change is