Skip to content

/ rust-harfbuzz

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to harfbuzz 2.5.0. #149

Merged
merged 2 commits into from May 28, 2019
Merged

Update to harfbuzz 2.5.0. #149

merged 2 commits into from May 28, 2019

Conversation

@waywardmonkeys
Copy link
Collaborator

waywardmonkeys commented May 26, 2019 •
edited by larsbergstrom

This change is Reviewable
@jdm
Copy link
Member

jdm commented May 26, 2019

Linux build is unhappy.
@waywardmonkeys
Copy link
Collaborator Author

waywardmonkeys commented May 26, 2019

@jdm Do you know offhand what version of gcc is being used on the Linux builds?

From the Harfbuzz 2.5.0 release notes:

This release does not include much functional changes, but includes major
internal code-base changes. We now require C++11. Support for gcc 4.8
and earlier has been dropped.
@jdm
Copy link
Member

jdm commented May 26, 2019

https://docs.travis-ci.com/user/languages/c/#c11c11-and-beyond-and-toolchain-versioning
@waywardmonkeys waywardmonkeys force-pushed the waywardmonkeys:update-to-harfbuzz-2.5.0 branch 2 times, most recently from 717cd04 to 920e417 May 26, 2019
@waywardmonkeys
Copy link
Collaborator Author

waywardmonkeys commented May 26, 2019

The Linux build is happy now (using gcc 5).

I could probably simplify the changes to .travis.yaml if desired.
@jdm
jdm requested changes May 26, 2019
View changes
.travis.yml Outdated Show resolved Hide resolved
@jdm
Copy link
Member

jdm commented May 26, 2019

Once those are fixed this is r=me.
@waywardmonkeys
Switch to gcc5 on Linux builds on Travis.
20a8cbc
@waywardmonkeys
Update to harfbuzz 2.5.0.
Loading status checks…
57f629e
@waywardmonkeys waywardmonkeys force-pushed the waywardmonkeys:update-to-harfbuzz-2.5.0 branch from 920e417 to 57f629e May 26, 2019
@waywardmonkeys
Copy link
Collaborator Author

waywardmonkeys commented May 28, 2019

@jdm I think this is ready for you to approve again!
@jdm
Copy link
Member

jdm commented May 28, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 28, 2019

📌 Commit 57f629e has been approved by jdm
bors-servo added a commit that referenced this pull request May 28, 2019
@bors-servo
Auto merge of #149 - waywardmonkeys:update-to-harfbuzz-2.5.0, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8bdf0d0 
Update to harfbuzz 2.5.0.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-harfbuzz/149)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 28, 2019

⌛ Testing commit 57f629e with merge 8bdf0d0...
@bors-servo
Copy link
Contributor

bors-servo commented May 28, 2019

☀️ Test successful - checks-travis
Approved by: jdm
Pushing 8bdf0d0 to master...
@bors-servo bors-servo merged commit 57f629e into servo:master May 28, 2019
3 checks passed
3 checks passed
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@waywardmonkeys waywardmonkeys deleted the waywardmonkeys:update-to-harfbuzz-2.5.0 branch May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@waywardmonkeys @jdm @bors-servo
You can’t perform that action at this time.