Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upbindgen now outputs f32 instead of c_float. #150
Closed
Conversation
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
May 28, 2019
bindgen now outputs f32 instead of c_float. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-harfbuzz/150) <!-- Reviewable:end -->
|
|
|
I'll look at those failures. |
|
Submitted a fix to |
|
It ends up that they argue that this is a bug in bindgen and so this change shouldn't land. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
waywardmonkeys commentedMay 28, 2019
•
edited by larsbergstrom
This change is