Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix harfbuzz-sys-test compilation with nightly. #159
Merged
Conversation
|
I found this while getting ready to do the update to Harfbuzz 2.6.0. |
The generated code depends upon libc, so make that explicit here.
waywardmonkeys
force-pushed the
waywardmonkeys:fix-sys-test
branch
from
9c10426
to
d5d2a1d
|
This is actually from updating to a more recent ctest. |
|
Also looks like our appveyor config is broken. |
|
If you pull in the commits from master...jdm-patch-3 that fix appveyor then we can merge these changes. |
|
@jdm Done. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 15, 2019
Fix harfbuzz-sys-test compilation with nightly. The generated code depends upon libc, so make that explicit here. Not sure why this worked before. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-harfbuzz/159) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
waywardmonkeys commentedAug 14, 2019
•
edited by larsbergstrom
The generated code depends upon libc, so make that explicit here.
Not sure why this worked before.
This change is