Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade core libs #180

Merged
merged 2 commits into from Apr 27, 2020
Merged

Upgrade core libs #180

merged 2 commits into from Apr 27, 2020

Conversation

@j4qfrost
Copy link
Contributor

j4qfrost commented Apr 27, 2020

This allows coverage using lcov and grcov. Related to this issue servo/core-foundation-rs#357

@jdm
Copy link
Member

jdm commented Apr 27, 2020

This can merge after #181.

core-graphics = "0.17"
core-text = "13"
core-graphics = ">=0.19"
core-text = ">=15"

This comment has been minimized.

@jdm

jdm Apr 27, 2020

Member

No need for the >=s. This can be "0.19" and "15" with the same effect.

This comment has been minimized.

@j4qfrost

j4qfrost Apr 27, 2020

Author Contributor

Done.

@jdm
Copy link
Member

jdm commented Apr 27, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Apr 27, 2020

📌 Commit 97b9d08 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Apr 27, 2020

Testing commit 97b9d08 with merge c848cec...

@bors-servo
Copy link
Contributor

bors-servo commented Apr 27, 2020

☀️ Test successful - checks-travis
Approved by: jdm
Pushing c848cec to master...

@bors-servo bors-servo merged commit c848cec into servo:master Apr 27, 2020
3 checks passed
3 checks passed
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.