Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCreate a new harfbuzz-sys crate #53
Merged
+165,723
−84,608
Conversation
* Follow -sys crate conventions * New FFI bindings built completely with bindgen * Can build HarfBuzz from source or link to it via pkg-config * Make ICU an optional feature with the icu-sys crate
Because ICU source is too big to be a Cargo package, and we can replace it with the pure rust unicode-script crate instead.
mbrubeck
force-pushed the
mbrubeck:harfbuzz-sys
branch
3 times, most recently
from
d9a6a10
to
be0955b
|
@bors-servo r+ |
|
|
bors-servo
pushed a commit
that referenced
this pull request
Sep 29, 2015
Create a new harfbuzz-sys crate * Upgrade to harfbuzz 1.0.3 * Follow `-sys` crate conventions * New FFI bindings built completely with rust-bindgen * Can build HarfBuzz from source or link to it via pkg-config * Make ICU an optional feature with the new `icu-sys` crate r? @larsberg <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-harfbuzz/53) <!-- Reviewable:end -->
|
|
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Sep 29, 2015
Use Harfbuzz 1.0 and unicode-script for text shaping Depends on servo/rust-harfbuzz#53 and introduces a dependency on the new servo/unicode-script crate. r? @pcwalton <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7786) <!-- Reviewable:end -->
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Sep 29, 2015
Use Harfbuzz 1.0 and unicode-script for text shaping Depends on servo/rust-harfbuzz#53 and introduces a dependency on the new servo/unicode-script crate. r? @pcwalton <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7786) <!-- Reviewable:end -->
jrmuizel
pushed a commit
to jrmuizel/gecko-cinnabar
that referenced
this pull request
Jun 12, 2017
…ping (from mbrubeck:harfbuzz-sys); r=pcwalton Depends on servo/rust-harfbuzz#53 and introduces a dependency on the new servo/unicode-script crate. r? @pcwalton Source-Repo: https://github.com/servo/servo Source-Revision: a144d086d911375f8d5674ac90ff55a9dcaf0cda
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Sep 30, 2019
…ping (from mbrubeck:harfbuzz-sys); r=pcwalton Depends on servo/rust-harfbuzz#53 and introduces a dependency on the new servo/unicode-script crate. r? pcwalton Source-Repo: https://github.com/servo/servo Source-Revision: a144d086d911375f8d5674ac90ff55a9dcaf0cda UltraBlame original commit: f66ad38ebe0b849d5d647707f20b8c2990d6b696
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 1, 2019
…ping (from mbrubeck:harfbuzz-sys); r=pcwalton Depends on servo/rust-harfbuzz#53 and introduces a dependency on the new servo/unicode-script crate. r? pcwalton Source-Repo: https://github.com/servo/servo Source-Revision: a144d086d911375f8d5674ac90ff55a9dcaf0cda UltraBlame original commit: f66ad38ebe0b849d5d647707f20b8c2990d6b696
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 1, 2019
…ping (from mbrubeck:harfbuzz-sys); r=pcwalton Depends on servo/rust-harfbuzz#53 and introduces a dependency on the new servo/unicode-script crate. r? pcwalton Source-Repo: https://github.com/servo/servo Source-Revision: a144d086d911375f8d5674ac90ff55a9dcaf0cda UltraBlame original commit: f66ad38ebe0b849d5d647707f20b8c2990d6b696
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mbrubeck commentedSep 25, 2015
-syscrate conventionsicu-syscrater? @larsberg