Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRevert "Move touch command into makefile.cargo" #60
+2
−23
Conversation
|
@bors-servo r+ Don't you love it when options are overloaded to do many things? Reviewed 3 of 3 files at r1. Comments from the review on Reviewable.io |
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 8, 2016
Revert "Move touch command into makefile.cargo" This reverts #58. The patch worked fine when building from git but broke when published to crates.io, because `cargo publish` does not package files in the `exclude` list. :( r? @metajack <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-harfbuzz/60) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mbrubeck commentedFeb 5, 2016
This reverts #58. The patch worked fine when building from git but broke when published to crates.io, because
cargo publishdoes not package files in theexcludelist. :(r? @metajack