Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional freetype support (Linux only) #65

Closed
wants to merge 3 commits into from
Closed

Conversation

@critiqjo
Copy link

critiqjo commented Sep 4, 2016

The example provided may be re-written with purely freetype-sys as dependency, in which case it may even be included as a test in the harfbuzz-sys crate (though, an additional font file+licence would have to be added then).

EDIT: The module name hb_ft may not be appropriate...?

EDIT2: I'm not sure how this can be made to work in Windows since I'm dynamic linking freetype and that is not quite straightforward there.


This change is Reviewable

@critiqjo
Copy link
Author

critiqjo commented Sep 4, 2016

As an aside, I'm planning to write a higher-level wrapper for Harfbuzz (with lesser flexibility). Should I make a pull request here (since both harfbuzz-sys and harfbuzz crates are linked to this repo), or should I create it separately and would you agree to transfer me the harfbuzz ownership in crates.io (at least if it is good enough)?

EDIT: Now that I think about it, the versions in harfbuzz crate is not yanked. So it may still be used in which case transferring it to me would be a bad idea. On the other hand, I myself might want to assign a different name for the new crate, since it will not be meant to replicate all of harfbuzz' features & flexibility.

Since this will break Windows build as it would not find the headers
required for freetype.
@critiqjo critiqjo force-pushed the critiqjo:ft branch from b8999c0 to 9f6b82d Sep 5, 2016
@critiqjo critiqjo changed the title Add optional freetype support Add optional freetype support (Linux only) Sep 5, 2016
@critiqjo
Copy link
Author

critiqjo commented Sep 6, 2016

Ah! I realized this is a bad idea! And for my use-case, I'll just use an always-dynamically-linked fork of this so that freetype and harfbuzz are always inter-compatible (ensured by the system's package manager).

@critiqjo critiqjo closed this Sep 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.