Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix android #68
Merged
Fix android #68
Conversation
|
This seems fragile, since we (or individual developers) could put things into |
|
Sure! That's coming in another PR (to servo/servo), and I can set it there, too. |
larsbergstrom
force-pushed the
larsbergstrom:fix_android
branch
from
df59bc2
to
aa26f3a
|
OK, fixed :-) |
|
@bors-servo r+ |
|
@bors-servo: r=mbrubeck |
|
|
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 23, 2016
Fix android r? @mbrubeck The issue here is that now that we're not using the NDK toolchain, the compilers won't "magically" figure out all of the include paths. These have all been set up in `CXXINCLUDE` but we need to pass them to `CPPINCLUDE` in order for the C preprocessor to also be able to pick up the hodge-podge of include directories. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-harfbuzz/68) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
larsbergstrom commentedOct 20, 2016
•
edited
r? @mbrubeck
The issue here is that now that we're not using the NDK toolchain, the compilers won't "magically" figure out all of the include paths. These have all been set up in
CXXINCLUDEbut we need to pass them toCPPINCLUDEin order for the C preprocessor to also be able to pick up the hodge-podge of include directories.This change is