Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd bindings to hb_ft_font_create_referenced. #69
Conversation
This allows creating a harfbuzz font directly from a FreeType face. Internally it increments the ref count of the FT face so that there are no lifetime issues. This allows much simpler use of the harfbuzz API rather than having to implement all the custom callback types, when using FT. It's exposed on all non-mac UNIX platforms (Linux, BSD etc) that are not Mac, and also on Android.
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
May 7, 2017
Add bindings to hb_ft_font_create_referenced. This allows creating a harfbuzz font directly from a FreeType face. Internally it increments the ref count of the FT face so that there are no lifetime issues. This allows much simpler use of the harfbuzz API rather than having to implement all the custom callback types, when using FT. It's exposed on all non-mac UNIX platforms (Linux, BSD etc) that are not Mac, and also on Android. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-harfbuzz/69) <!-- Reviewable:end -->
|
|
MortimerGoro
added a commit
to MortimerGoro/rust-harfbuzz
that referenced
this pull request
May 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
glennw commentedMay 7, 2017
•
edited by larsbergstrom
This allows creating a harfbuzz font directly from a FreeType
face. Internally it increments the ref count of the FT face
so that there are no lifetime issues.
This allows much simpler use of the harfbuzz API rather than
having to implement all the custom callback types, when
using FT.
It's exposed on all non-mac UNIX platforms (Linux, BSD etc)
that are not Mac, and also on Android.
This change is