Skip to content

/ rust-harfbuzz

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Cargo metadata so dependents can find hb.h #73

Merged
merged 1 commit into from Jun 1, 2017
Merged

Set Cargo metadata so dependents can find hb.h #73

merged 1 commit into from Jun 1, 2017

Conversation

@chris-morgan
Copy link
Contributor

chris-morgan commented Jun 1, 2017 •
edited by larsbergstrom

This change is Reviewable
@chris-morgan
Set Cargo metadata so dependents can find hb.h
Loading status checks…
dfdfc86
@chris-morgan chris-morgan force-pushed the chris-morgan:DEP_HARFBUZZ_INCLUDE branch from c552d51 to dfdfc86 Jun 1, 2017
@chris-morgan
Copy link
Contributor Author

chris-morgan commented Jun 1, 2017

Note: my initial implementation used fs::canonicalize(Path::new("harfbuzz/src")).unwrap(), but that produces \\?\C:\…-style paths on Windows, which, while theoretically superior, don’t appear to play well with cl as an include path. I’ve changed it to use env::current_dir().unwrap().join("harfbuzz/src") which doesn’t suffer from this problem.
@jdm
Copy link
Member

jdm commented Jun 1, 2017

@bors-servo: r+
Looks reasonable to me!
@bors-servo
Copy link
Contributor

bors-servo commented Jun 1, 2017

📌 Commit dfdfc86 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jun 1, 2017

⌛ Testing commit dfdfc86 with merge ae51974...
bors-servo added a commit that referenced this pull request Jun 1, 2017
@bors-servo
Auto merge of #73 - chris-morgan:DEP_HARFBUZZ_INCLUDE, r=jdm
Loading status checks…
ae51974 
Set Cargo metadata so dependents can find hb.h

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-harfbuzz/73)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 1, 2017

☀️ Test successful - status-travis
Approved by: jdm
Pushing ae51974 to master...
@bors-servo bors-servo merged commit dfdfc86 into servo:master Jun 1, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@chris-morgan chris-morgan mentioned this pull request Jun 7, 2017
Closed
@chris-morgan chris-morgan deleted the chris-morgan:DEP_HARFBUZZ_INCLUDE branch Jun 12, 2017
@chris-morgan
Copy link
Contributor Author

chris-morgan commented Jun 12, 2017

Any chance of a 0.1.11 release now that this has been merged?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@chris-morgan @jdm @bors-servo
You can’t perform that action at this time.