Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[breaking change] Stop exporting libc and cpp definitions. #86
Conversation
These definitions aren't needed and are just a relic of how bindgen works. They shouldn't be exported and since they aren't used, they don't need to exist.
|
Ping? I would like to submit a PR that logically comes after this one so that there is no conflict. |
|
I'd like to get out of the habit of editing generated code (though I'm guilty of it myself), and instead use bindgen options to control the output when it is generated. Would you be interested in adding a bindgen script (it could be a simple shell script or similar), which we can then tweak to blacklist items that we don't want? |
|
The extra types involved are different on each platform which makes it a bit trickier. I had been thinking of adding doc comments to this as well so that the Rust docs are more usable. (It ends up that Harfbuzz docs themselves are a bit scattered.) I have done this with some of my own crates where I don’t keep running bindgen. This also comes into play with enums and bitflags. |
|
Yeah, that makes sense. Any thoughts about how to handle regenerating bindings (e.g. for harfbuzz upgrades)? Maybe we should have a separate branch that just has the generated bindings, and merge that into the master branch (which includes patches to the bindings) whenever it changes. |
mbrubeck
changed the title
|
Merging this for now; we can deal with the code generation issue later. |
|
@bors-servo r+ |
|
|
[breaking change] Stop exporting libc and cpp definitions. These definitions aren't needed and are just a relic of how bindgen works. They shouldn't be exported and since they aren't used, they don't need to exist. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-harfbuzz/86) <!-- Reviewable:end -->
|
|
waywardmonkeys commentedDec 16, 2017
•
edited by larsbergstrom
These definitions aren't needed and are just a relic of how bindgen
works. They shouldn't be exported and since they aren't used, they
don't need to exist.
This change is