Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[breaking change] Use ::std::os::raw instead of libc. #91

Merged
merged 1 commit into from Dec 22, 2017

Conversation

@waywardmonkeys
Copy link
Collaborator

waywardmonkeys commented Dec 22, 2017

This is a breaking change.

Fixes issue #88.


This change is Reviewable

This is a breaking change.

Fixes issue #88.
@waywardmonkeys
Copy link
Collaborator Author

waywardmonkeys commented Dec 22, 2017

After this, I can do the update of harfbuzz to 1.7.x and re-generate with bindgen and hopefully be closer to using the bindgen output again, but this will help to minimize the diff and separate changes out.

@mbrubeck mbrubeck changed the title Use ::std::os::raw instead of libc. [breaking change] Use ::std::os::raw instead of libc. Dec 22, 2017
@mbrubeck
Copy link
Contributor

mbrubeck commented Dec 22, 2017

@bors-servo
Copy link
Contributor

bors-servo commented Dec 22, 2017

📌 Commit 2704705 has been approved by mbrubeck

@bors-servo
Copy link
Contributor

bors-servo commented Dec 22, 2017

Testing commit 2704705 with merge f163d64...

bors-servo added a commit that referenced this pull request Dec 22, 2017
[breaking change] Use ::std::os::raw instead of libc.

This is a breaking change.

Fixes issue #88.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-harfbuzz/91)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 22, 2017

💔 Test failed - status-travis

@mbrubeck
Copy link
Contributor

mbrubeck commented Dec 22, 2017

@bors-servo retry

  • Travis build was canceled?
@bors-servo
Copy link
Contributor

bors-servo commented Dec 22, 2017

Testing commit 2704705 with merge ff81f10...

bors-servo added a commit that referenced this pull request Dec 22, 2017
[breaking change] Use ::std::os::raw instead of libc.

This is a breaking change.

Fixes issue #88.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-harfbuzz/91)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 22, 2017

💔 Test failed - status-travis

@bors-servo
Copy link
Contributor

bors-servo commented Dec 22, 2017

☀️ Test successful - status-travis
Approved by: mbrubeck
Pushing ff81f10 to master...

@bors-servo bors-servo merged commit 2704705 into servo:master Dec 22, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@waywardmonkeys waywardmonkeys deleted the waywardmonkeys:remove-libc branch Dec 22, 2017
@waywardmonkeys
Copy link
Collaborator Author

waywardmonkeys commented Dec 22, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.