Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[breaking change] No longer provide HB_VERSION_*. #96
Conversation
The version constants were for the version of the library that was present when the bindings were generated, not the version that is actually present at runtime. Checks should be done against the version present at runtime using `hb_version_*`. This is a breaking change.
waywardmonkeys
changed the title
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 13, 2018
[breaking change] No longer provide HB_VERSION_*. The version constants were for the version of the library that was present when the bindings were generated, not the version that is actually present at runtime. Checks should be done against the version present at runtime using `hb_version_*`. This is a breaking change. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-harfbuzz/96) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Jan 13, 2018
[breaking change] No longer provide HB_VERSION_*. The version constants were for the version of the library that was present when the bindings were generated, not the version that is actually present at runtime. Checks should be done against the version present at runtime using `hb_version_*`. This is a breaking change. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-harfbuzz/96) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
waywardmonkeys commentedJan 12, 2018
•
edited by larsbergstrom
The version constants were for the version of the library that
was present when the bindings were generated, not the version
that is actually present at runtime. Checks should be done against
the version present at runtime using
hb_version_*.This is a breaking change.
This change is