Skip to content

/ rust-harfbuzz

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update harfbuzz 1.7.4 #99

Merged
merged 3 commits into from Jan 19, 2018
Merged

Update harfbuzz 1.7.4 #99

merged 3 commits into from Jan 19, 2018
+27,672 −15,424

Conversation

@waywardmonkeys
Copy link
Collaborator

waywardmonkeys commented Jan 14, 2018 •
edited by larsbergstrom

Fixes issue #89.

This change is Reviewable
@waywardmonkeys
Copy link
Collaborator Author

waywardmonkeys commented Jan 14, 2018

This might be interesting to see how it deals with Windows.
@jdm
Copy link
Member

jdm commented Jan 15, 2018

We should probably add appveyor integration, in that case. @larsbergstrom could you flip that switch?
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Jan 15, 2018

@jdm Appveyor is now enabled for this repository.
@jdm
Copy link
Member

jdm commented Jan 15, 2018

I've opened #100.
@waywardmonkeys waywardmonkeys mentioned this pull request Jan 16, 2018
Closed
@waywardmonkeys
Copy link
Collaborator Author

waywardmonkeys commented Jan 18, 2018

This is waiting for #100 to land and then once we know this works on Windows, it can hopefully land?
@jdm
Copy link
Member

jdm commented Jan 18, 2018

Yes, that's fine from my perspective.
@jdm
Copy link
Member

jdm commented Jan 18, 2018

@waywardmonkeys Could you rebase and push so this gets an appveyor run?
@waywardmonkeys
Update from harfbuzz 1.4.8 to 1.7.4.
d220dc0
@waywardmonkeys
Update bindings for harfbuzz 1.7.4.
Loading status checks…
63e6423 
Fixes issue #89.
@waywardmonkeys waywardmonkeys force-pushed the waywardmonkeys:update-harfbuzz-1.7.4 branch from 32a37ef to 63e6423 Jan 19, 2018
@waywardmonkeys
Copy link
Collaborator Author

waywardmonkeys commented Jan 19, 2018

@jdm Done.
@waywardmonkeys
Copy link
Collaborator Author

waywardmonkeys commented Jan 19, 2018

The upstream 1.7.4 release is apparently broken for cmake builds ... I'll submit a fix upstream and then add the missing file here and re-force push. (Probably in about an hour.)
@waywardmonkeys waywardmonkeys force-pushed the waywardmonkeys:update-harfbuzz-1.7.4 branch from b926175 to 0ec99e2 Jan 19, 2018
@waywardmonkeys
Disable cmake tests in imported harfbuzz code.
Loading status checks…
17bb7e8 
This doesn't work because the files that it needs weren't included
in this release. But we don't run the harfbuzz tests, so this isn't
an issue for us. Also, up until now, there hadn't been working
support for tests on Windows.
@waywardmonkeys waywardmonkeys force-pushed the waywardmonkeys:update-harfbuzz-1.7.4 branch from 0ec99e2 to 17bb7e8 Jan 19, 2018
@jdm
Copy link
Member

jdm commented Jan 19, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jan 19, 2018

📌 Commit 17bb7e8 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jan 19, 2018

⌛ Testing commit 17bb7e8 with merge 422d181...
bors-servo added a commit that referenced this pull request Jan 19, 2018
@bors-servo
Auto merge of #99 - waywardmonkeys:update-harfbuzz-1.7.4, r=jdm
Loading status checks…
422d181 
Update harfbuzz 1.7.4

Fixes issue #89.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-harfbuzz/99)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 19, 2018

☀️ Test successful - status-travis
Approved by: jdm
Pushing 422d181 to master...
@bors-servo bors-servo merged commit 17bb7e8 into servo:master Jan 19, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@waywardmonkeys waywardmonkeys deleted the waywardmonkeys:update-harfbuzz-1.7.4 branch Jan 19, 2018
@waywardmonkeys waywardmonkeys mentioned this pull request Jan 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@waywardmonkeys @jdm @larsbergstrom @bors-servo
You can’t perform that action at this time.