Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GLSL precision specifier for android. #100

Merged
merged 1 commit into from Aug 11, 2014
Merged

Conversation

@glennw
Copy link
Member

glennw commented Aug 11, 2014

No description provided.

@zwarich
Copy link
Contributor

zwarich commented Aug 11, 2014

Can we just do this unconditionally rather than adding an #ifdef?

@glennw
Copy link
Member Author

glennw commented Aug 11, 2014

@glennw
Copy link
Member Author

glennw commented Aug 11, 2014

I'm not sure if all desktop GLSL compilers handle that syntax (even though they should by spec) - it seems safer to follow the convention that the other shaders are using.

@zwarich
Copy link
Contributor

zwarich commented Aug 11, 2014

Sigh, Linux OpenGL.

zwarich pushed a commit that referenced this pull request Aug 11, 2014
Add GLSL precision specifier for android.
@zwarich zwarich merged commit 016b896 into servo:master Aug 11, 2014
@glennw glennw deleted the glennw:android-fix branch Aug 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.