Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upStart using typed units in rust-layers #102
Merged
+75
−45
Conversation
tiling.rs
Outdated
| @@ -222,15 +233,15 @@ impl TileGrid { | |||
| } | |||
| } | |||
|
|
|||
| self.mark_tiles_outside_of_rect_as_unused(rect_in_layer_pixels); | |||
| self.mark_tiles_outside_of_rect_as_unused(rect_in_layer); | |||
| return buffer_requests; | |||
| } | |||
|
|
|||
| pub fn get_tile_index_for_point(&self, point: Point2D<uint>) -> Point2D<uint> { | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mrobinson
Aug 27, 2014
Author
Member
Yeah, eventually when LayerBuffer is using typed units it will make sense to use TypedPoint here. By avoiding a change to the argument now I can do this process all in one commit.
zwarich
pushed a commit
that referenced
this pull request
Aug 27, 2014
Start using typed units in rust-layers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mrobinson commentedAug 22, 2014
This allows conversion between unit types which are self-documenting and helps prevent the introduction of errors or confusion about unit types.