Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upStore content offset in unscaled pixels #108
Merged
+21
−16
Conversation
This is necessary because the renderer pre-scales the scene when applying content offset. We also store a scene scale instead of a scene transformation, so that we know how to properly deal with device pixels. Also ensures that content offset is not accumulated when rendering layers.
zwarich
pushed a commit
that referenced
this pull request
Sep 12, 2014
Store content offset in unscaled pixels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mrobinson commentedSep 12, 2014
This is necessary because the renderer pre-scales the scene when
applying content offset. We also store a scene scale instead of a scene
transformation, so that we know how to properly deal with device pixels.
Also ensures that content offset is not accumulated when rendering
layers.