New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First steps to allowing Linux to use EGL and OpenGLES #220

Closed
wants to merge 30 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@prashantgupta24

prashantgupta24 commented Dec 7, 2015

Review on Reviewable

@glennw

This comment has been minimized.

Show comment
Hide comment
@glennw

glennw Dec 7, 2015

Member

Reviewed 2 of 4 files at r1, 3 of 3 files at r4.
Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.


src/platform/egl/surface.rs, line 71 [r4] (raw file):
BGRA constant only exists on Linux - we'll need to apply the same trick I have done here (https://github.com/glennw/webrender/blob/master/src/device.rs#L16) to support BGRA on Linux and BGRA_EXT on Android.


src/platform/egl/surface.rs, line 85 [r4] (raw file):
Tabs -> spaces


Comments from the review on Reviewable.io

Member

glennw commented Dec 7, 2015

Reviewed 2 of 4 files at r1, 3 of 3 files at r4.
Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.


src/platform/egl/surface.rs, line 71 [r4] (raw file):
BGRA constant only exists on Linux - we'll need to apply the same trick I have done here (https://github.com/glennw/webrender/blob/master/src/device.rs#L16) to support BGRA on Linux and BGRA_EXT on Android.


src/platform/egl/surface.rs, line 85 [r4] (raw file):
Tabs -> spaces


Comments from the review on Reviewable.io

@glennw

This comment has been minimized.

Show comment
Hide comment
@glennw

glennw Dec 7, 2015

Member

Just a few minor changes left - nearly there! :)

Member

glennw commented Dec 7, 2015

Just a few minor changes left - nearly there! :)

@glennw

This comment has been minimized.

Show comment
Hide comment
@glennw

glennw Dec 10, 2015

Member

This looks good to me (well, it will still need a rebase + squash) - but I'd like to get @mrobinson to check over it too.

Member

glennw commented Dec 10, 2015

This looks good to me (well, it will still need a rebase + squash) - but I'd like to get @mrobinson to check over it too.

display: self.display,
visual_info: self.visual_info,
match *self {
NativeDisplay::Glx(info) => {

This comment has been minimized.

@mrobinson

mrobinson Dec 14, 2015

Member

This should still be called GLX instead of Glx.

@mrobinson

mrobinson Dec 14, 2015

Member

This should still be called GLX instead of Glx.

visual_info: info.visual_info,
}
}
NativeDisplay::Egl(_) => unreachable!(),

This comment has been minimized.

@mrobinson

mrobinson Dec 14, 2015

Member

And here EGL instead of Egl.

@mrobinson

mrobinson Dec 14, 2015

Member

And here EGL instead of Egl.

}
}
pub fn from_es2() -> NativeDisplay {

This comment has been minimized.

@mrobinson

mrobinson Dec 14, 2015

Member

I think maybe this should be called new_egl_display instead of from_es2. GLES2 is a different concept than EGL.

@mrobinson

mrobinson Dec 14, 2015

Member

I think maybe this should be called new_egl_display instead of from_es2. GLES2 is a different concept than EGL.

@mrobinson

This comment has been minimized.

Show comment
Hide comment
@mrobinson

mrobinson Dec 14, 2015

Member

Looks good to me, apart from a few minor style and naming issues.

Member

mrobinson commented Dec 14, 2015

Looks good to me, apart from a few minor style and naming issues.

@gdamjan gdamjan referenced this pull request Dec 22, 2015

Closed

Wayland support #332

@larsbergstrom larsbergstrom referenced this pull request Dec 28, 2015

Merged

twis45 #50

@jdm

This comment has been minimized.

Show comment
Hide comment
@jdm

jdm Feb 27, 2016

Member

Rebased, squashed and comments addressed in #232.

Member

jdm commented Feb 27, 2016

Rebased, squashed and comments addressed in #232.

@jdm jdm closed this Feb 27, 2016

bors-servo added a commit that referenced this pull request Feb 28, 2016

Auto merge of #232 - jdm:egl_linux, r=glennw
Support EGL on non-Android Linux.

Rebase and squash of #220.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-layers/232)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment