Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upOnly apply nvidia hack with nvidia drivers #67
Conversation
Check the GLX vendor string for nvidia before applying nvidia driver hack.
| } | ||
| } | ||
| }else if number_of_configs != 0 { |
This comment has been minimized.
This comment has been minimized.
| if (*visual_info).depth == 32 { | ||
| return (visual_info, Some(config)) | ||
| let glXGetClientString: extern "C" fn(*Display, c_int) -> *c_char = | ||
| cast::transmute(glXGetProcAddress(cast::transmute(&"glXGetClientString\x00"[0]))); |
This comment has been minimized.
This comment has been minimized.
| let glXGetClientString: extern "C" fn(*Display, c_int) -> *c_char = | ||
| cast::transmute(glXGetProcAddress(cast::transmute(&"glXGetClientString\x00"[0]))); | ||
| assert!(glXGetClientString as *c_void != ptr::null()); | ||
| let glx_client_vendor = glXGetClientString(display, 1); |
This comment has been minimized.
This comment has been minimized.
bjwbell
May 27, 2014
Author
Contributor
Will replace 1 -> GLX_VENDOR after merge of PR Add GLX_VENDOR define
|
This seems to be the solution used in Gecko as well: https://bugzilla.mozilla.org/show_bug.cgi?id=896287 |
|
Shoot they match on glx server vendor string. I'm matching on the client. Can you test? (maybe try it with X11 ssh forwarding too??) I don't have any Nvidia systems. |
|
I get this error: src/support/layers/rust-layers/platform/linux/surface.rs:25:21: 25:31 error: unresolved import: there is no When I just use 1 instead of GLX_VENDOR the patch works great. |
|
Great. To fix the error update to the newest version of rust-opengles (servo/rust-opengles#83) |
This comment has been minimized.
This comment has been minimized.
pcwalton
commented on 6de7f80
May 27, 2014
|
r+ |
Only apply nvidia hack with nvidia drivers
bjwbell commentedMay 27, 2014
Check the GLX vendor string for nvidia before applying nvidia driver hack.
See commit 04aeadbfbe.
@mrobinson