Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow rust-layers to stop caring about the Servo content scale #90

Merged
merged 2 commits into from Jul 29, 2014

Conversation

@mrobinson
Copy link
Member

mrobinson commented Jul 29, 2014

These commits allow rust-layers to store all layer boundaries in device/layer coordinates instead of Servo page coordinates. Additionally, BufferRequests are now returned in device/layer coordinates as well. Servo will take care of converting them to page coordinates.

mrobinson added 2 commits Jul 25, 2014
In Servo layer bounds are now stored in layer/device coordinates and the
Servo compositor takes care of converting buffer requests to page
coordinates before passing them to the render task.
@zwarich

This comment has been minimized.

Copy link

zwarich commented on layers.rs in e3515fc Jul 29, 2014

Is rust-layers actually going to need to use the content_offset? I assume so, since it needs to render scrolled layers at the right position.

This comment has been minimized.

Copy link
Owner Author

mrobinson replied Jul 29, 2014

Yes, rust-layers will need two types of transformations per layer. The content_offset is used to adjust the position of tiles within the layer area.

This comment has been minimized.

Copy link

zwarich replied Jul 29, 2014

I guess my question is: if rust-layers isn't using content_offset yet, does it need to be added in this PR? Or does rust-layers need to expose it so that Servo can use it before rust-layers can use it?

This comment has been minimized.

Copy link
Owner Author

mrobinson replied Jul 29, 2014

Yes, exactly right. rust-layers exposes it so that it can be used in get_buffer_requests_recursively in Servo. In a later patch I will move get_buffer_requests_recursively entirely into rust-layers.

zwarich pushed a commit that referenced this pull request Jul 29, 2014
Allow rust-layers to stop caring about the Servo content scale
@zwarich zwarich merged commit 5f3dc4c into servo:master Jul 29, 2014
@mrobinson mrobinson deleted the mrobinson:disentangle-scale branch Jul 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.