Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMove get_buffer_requests into rust-layers from Servo #94
Conversation
|
|
||
| self.get_buffer_requests_for_layer(root_layer.clone(), | ||
| requests, | ||
| window_rect_in_device_pixels); |
This comment has been minimized.
This comment has been minimized.
zwarich
Jul 30, 2014
Contributor
It seems like the nesting here wouldn't be too bad if this were just a plain match, rather a match with an early return defining a local.
This comment has been minimized.
This comment has been minimized.
mrobinson
Jul 30, 2014
Author
Member
I had to do this do avoid a double borrow actually. Rust complained that I borrowed self twice, once for self.root and once for self.get_buffer_requests_for_layer.
|
I found a bug in this pull requests, but I will update it soon with a fixed version. |
This is generally useful and layers now know how to get their own BufferRequests.
|
Okay. I've fixed the bug in the previous version of the PR. Things seem to be working well now. |
zwarich
pushed a commit
that referenced
this pull request
Jul 31, 2014
Move get_buffer_requests into rust-layers from Servo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mrobinson commentedJul 30, 2014
This is generally useful and layers now know how to get their own
BufferRequests.