Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix use-after-free on Android. #95
Merged
Conversation
Fixes servo/servo#2916 (broken rendering on Android), which happened because the `bitmap` pointer outlived the Vec<u8> that it pointed to.
mbrubeck
added a commit
to mbrubeck/servo
that referenced
this pull request
Jul 30, 2014
Required for servo/rust-layers#95.
|
As requested by @Ms2ger, changed NativeSurface::upload to take |
This comment has been minimized.
This comment has been minimized.
metajack
commented on 6f3053a
Jul 30, 2014
|
r+ |
metajack
added a commit
that referenced
this pull request
Jul 30, 2014
Fix use-after-free on Android.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mbrubeck commentedJul 30, 2014
Fixes servo/servo#2916 (broken rendering on Android), which happened because the
bitmappointer outlived the Vec that it pointed to.