Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAllow marking all layers as having changed contents #97
Conversation
|
I rebased this to the latest and it should be ready to go now. |
layers.rs
Outdated
| fn partial_cmp(&self, other: &ContentAge) -> Option<Ordering> { | ||
| return Some(self.age.cmp(&other.age)); | ||
| } | ||
| } |
This comment has been minimized.
This comment has been minimized.
scene.rs
Outdated
| for kid in layer.children().iter() { | ||
| self.mark_all_layers_contents_as_changed_for_layer(kid.clone()); | ||
| } | ||
| } |
This comment has been minimized.
This comment has been minimized.
zwarich
Aug 13, 2014
Contributor
The name mark_all_layer_contents_as_changed_for_layer seems better, since it's not eliding an apostrophe that can't be written in an identifier.
scene.rs
Outdated
| None => return, | ||
| }; | ||
| self.mark_all_layers_contents_as_changed_for_layer(root_layer); | ||
| } |
This comment has been minimized.
This comment has been minimized.
|
Thanks for the review. I chose to rename mark_all_layers_contents_as_changed to mark_layer_contents_changed_recursively. |
zwarich
pushed a commit
that referenced
this pull request
Aug 15, 2014
Allow marking all layers as having changed contents
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mrobinson commentedAug 3, 2014
Allow marking all layers as having changed contents, so that we can support updating all layers immediately with high-resolution tiles when pinch zoom finishes. This PR also includes more robust tracking of content_age, which should make bad behavior from the client easier to detect.