Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRust 0.6 syntax #10
Merged
Rust 0.6 syntax #10
Conversation
This comment has been minimized.
This comment has been minimized.
jdm
commented on crust.rs in 849389c
Apr 2, 2013
|
This isn't correct; we need to ensure that structs are passed by value, which requires the + mode right now. |
This comment has been minimized.
This comment has been minimized.
|
I was told that ++ is unused now. Did I misunderstand something? The compiler throws a warning here on |
This comment has been minimized.
This comment has been minimized.
jdm
commented on rust.rs in 849389c
Apr 2, 2013
|
I think it should be possible to use mutable references to Cx and avoid making classes managed. This should avoid the need for the unsafe_destructor attribute as well. |
This comment has been minimized.
This comment has been minimized.
jdm
commented on rust.rs in 849389c
Apr 2, 2013
|
Similarly, it feels like we shouldn't need to make this managed, just ensure we have mutable references to Compartment. |
mmatyas
pushed a commit
to mmatyas/rust-mozjs
that referenced
this pull request
Jul 30, 2015
Linux font fixes
tschneidereit
pushed a commit
to tschneidereit/rust-mozjs
that referenced
this pull request
Aug 26, 2017
Silence unused-local-typedefs warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
metajack commentedApr 1, 2013
No description provided.