Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upIssue #108 - Use rexport_test_harness_main to run test with libgreen. #109
Conversation
|
I think |
kmcallister
added a commit
that referenced
this pull request
Oct 5, 2014
|
What happened to not touching rust-mozjs before the SM upgrade lands? :( |
|
Sorry, I forgot :/ You can back out the change if you want, I think force-pushing |
mmatyas
pushed a commit
to mmatyas/rust-mozjs
that referenced
this pull request
Jul 30, 2015
Fix cfg for linux/android during rust upgrade
tschneidereit
pushed a commit
to tschneidereit/rust-mozjs
that referenced
this pull request
Aug 26, 2017
More portable way to set SHELL to bash. This is the only problem I found while trying to build on NixOS (the usual problem from the unpatched virtualenv that SpiderMonkey bundles seems to have fixed itself so🎉 ). <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/109) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mukilan commentedOct 5, 2014
Fixes issue #108