Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix JSVal::is_boolean #113
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
jdm
commented on 5f37be6
Oct 17, 2014
|
Can you explain why this change is necessary? |
This comment has been minimized.
This comment has been minimized.
jdm
replied
Oct 17, 2014
|
Hmm, it does match JSVAL_IS_BOOLEAN_IMPL in Value.h. |
This comment has been minimized.
This comment has been minimized.
|
If JSVal is true then self.v will be (shifted_tag | 1). Hence comparison will fail. |
This comment has been minimized.
This comment has been minimized.
jdm
replied
Oct 17, 2014
|
Ooh, that's no good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mukilan commentedOct 17, 2014
No description provided.