Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAllow the user to set their own GC callback #115
Merged
+2
−1
Conversation
jdm
added a commit
that referenced
this pull request
Oct 24, 2014
Allow the user to set their own GC callback
tschneidereit
pushed a commit
to tschneidereit/rust-mozjs
that referenced
this pull request
Aug 26, 2017
Make it compile for Android x86 (i686)
For Android x86 the `ANDROID_NDK` environment variable isn't passed
on correctly. Without this change it's not possible to compile the
`mozjs_sys` crate for Android x86, it would fail with:
Reexecuting in the virtualenv
checking for a shell... /bin/sh
checking for host system type... x86_64-pc-linux-gnu
checking for target system type... i686-pc-linux-android
checking for the Android toolchain directory... not found
...
configure: error: not found. Please check your NDK. With the current configuration, it should be in /platforms/android-9/arch-x86
With this change it's possible to compile it successfully for Android
x86 with:
PATH=$PATH:<x86-toolchain>/bin ANDROID_NDK=<android-ndk-r12b> cargo build --target i686-linux-android --verbose
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/115)
<!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kmcallister commentedOct 24, 2014
No description provided.