Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upenable all typed array function #135
Merged
+26
−1
Conversation
src/jsfriendapi.rs
Outdated
| @@ -25,13 +25,38 @@ pub fn JS_WrapPropertyDescriptor(cx: *mut JSContext, | |||
|
|
|||
| pub mod bindgen { | |||
| use jsapi::{JSContext, JSObject, JSClass, JSRuntime}; | |||
| use libc::{uintptr_t, uint8_t, uint32_t}; | |||
| use libc::{uintptr_t, int8_t, uint8_t, int16_t, uint16_6, int32_t, uint32_t, float32_t, float64_t}; | |||
This comment has been minimized.
This comment has been minimized.
Ms2ger
Feb 19, 2015
Collaborator
uint16_6 should be uint16_t; float32_t and float64_t should be c_float and c_double, respectively.
src/jsfriendapi.rs
Outdated
|
|
||
| extern { | ||
| pub fn JS_NewObjectWithUniqueType(cx: *mut JSContext, clasp: *const JSClass, | ||
| proto: *const JSObject, parent: *const JSObject) -> *mut JSObject; | ||
| pub fn JS_GetAddressableObject(rt: *mut JSRuntime, candidateObj: uintptr_t) -> *mut JSObject; | ||
|
|
||
| pub fn JS_NewInt8Array (cx: *mut JSContext, nelements: uint32_t) -> *mut JSObject; |
This comment has been minimized.
This comment has been minimized.
|
Kill |
Ms2ger
added a commit
that referenced
this pull request
Feb 19, 2015
Enable all typed array functions; r=Ms2ger
mmatyas
pushed a commit
to mmatyas/rust-mozjs
that referenced
this pull request
Jul 30, 2015
Update rustc to 00b112c45a604fa6f4b59af2a40c9deeadfdb7c6/rustc-1.0.0-dev; r=Ms2ger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
yodalee commentedFeb 19, 2015
Follow PR #128, enable all typed array function