Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement finalizeInBackground. #159
Merged
+10
−0
Conversation
This prevents SM from silently finalizing objects off the JSRuntime's thread.
|
@Ms2ger Why is this needed? |
|
Without this, we end up calling |
|
Out of curiosity, does Firefox let the JS engine finalize in the background? How do they deal with it? |
|
@bors-servo r+ |
|
|
bors-servo
pushed a commit
that referenced
this pull request
Jun 21, 2015
Implement finalizeInBackground. This prevents SM from silently finalizing objects off the JSRuntime's thread.
|
|
Ms2ger
added a commit
that referenced
this pull request
Jun 21, 2015
Implement finalizeInBackground; r=jack
|
Gecko doesn't allow it either. |
mmatyas
pushed a commit
to mmatyas/rust-mozjs
that referenced
this pull request
Jul 30, 2015
Using x11-rs for X11 bindings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Ms2ger commentedJun 21, 2015
This prevents SM from silently finalizing objects off the JSRuntime's thread.