Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake cargo test work #168
Merged
Make cargo test work #168
Conversation
src/rust.rs
Outdated
|
|
||
| #[test] | ||
| pub fn dummy() { | ||
| unsafe { JS_Init(); } |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
I don't understand the linkhack change, but then again, I don't know if anybody does. Does Servo compile with this change? |
|
Yeah, I checked on Linux. |
|
I mostly understand what's going on with the linkhack now. I just don't know how it worked before. |
|
Commit updated to use assert_eq, same as in servo. |
|
@bors-servo r+ |
|
|
bors-servo
pushed a commit
that referenced
this pull request
Jul 3, 2015
|
|
bors-servo
merged commit 73d2824
into
servo:master
1 check was pending
1 check was pending
mmatyas
pushed a commit
to mmatyas/rust-mozjs
that referenced
this pull request
Jul 30, 2015
Porting to raspberry pi2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
michaelwu commentedJul 2, 2015
Fixes #161