Skip to content

/ rust-mozjs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add glue to use SpiderMonkey's memory reporting from Rust code. #177

Merged
merged 1 commit into from Jul 14, 2015
Merged

Add glue to use SpiderMonkey's memory reporting from Rust code. #177

merged 1 commit into from Jul 14, 2015

Conversation

@nnethercote
Copy link
Contributor

nnethercote commented Jul 8, 2015

This cannot land until servo/mozjs#49 has landed. And it must land before servo/servo#6572 can land.
@nnethercote
Add glue to use SpiderMonkey's memory reporting from Rust code.
Loading status checks…
a802d31
@nnethercote nnethercote mentioned this pull request Jul 8, 2015
Merged
@michaelwu
Copy link
Contributor

michaelwu commented Jul 8, 2015

For this particular API, C++ glue is not necessary. https://github.com/michaelwu/rust-bindgen/tree/sm-hacks along with https://github.com/michaelwu/llvm and https://github.com/michaelwu/clang will do the trick. I can generate some bindings for you if you want - it's a bit of a hassle to setup bindgen.
@michaelwu
Copy link
Contributor

michaelwu commented Jul 8, 2015

For reference, https://gist.github.com/michaelwu/9f10f60dc8b2c8e881cd is the bindgen output on MemoryMetrics.h (without your sm patch). Needs a bit of cleanup to work, especially since this file seems to trigger a few new features I haven't fully tested yet. Constructing and destructing C++ objects may require C++ glue, but many other things can be covered by the generator.
@jdm
Copy link
Member

jdm commented Jul 14, 2015

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 14, 2015

📌 Commit a802d31 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Jul 14, 2015

⌛ Testing commit a802d31 with merge 9509978...
bors-servo pushed a commit that referenced this pull request Jul 14, 2015
bors-servo
Auto merge of #177 - nnethercote:reporting, r=jdm
9509978 
Add glue to use SpiderMonkey's memory reporting from Rust code.

This cannot land until servo/mozjs#49 has landed. And it must land before servo/servo#6572 can land.
@bors-servo
Copy link
Contributor

bors-servo commented Jul 14, 2015

☀️ Test successful - cargo-linux, cargo-mac
@bors-servo bors-servo merged commit a802d31 into servo:master Jul 14, 2015
1 check passed
1 check passed
homu Test successful
Details
mmatyas pushed a commit to mmatyas/rust-mozjs that referenced this pull request Jul 30, 2015
bors-servo
Auto merge of servo#177 - pcwalton:pattern-matrix, r=glennw
d8c86d7 
Allow the matrix to be supplied for surface patterns.

Required to get tiling working right.

r? @glennw
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@nnethercote @michaelwu @jdm @bors-servo
You can’t perform that action at this time.