Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upReplace `i8` with `libc::c_char` #179
Merged
Conversation
It is definitely suboptimal to manually edit autogenerated code and surely incomplete but, at least, gets servo build on platforms where char is unsigned (e.g., on aarch64). It would be great if a future version of bindgen could generate `libc::c_char` at the right places.
|
cc @michaelwu |
|
Now fixed in bindgen++ michaelwu/rust-bindgen@1c10ec4 r=me for this PR which will cover things until the next bindings update. |
|
@bors-servo: r+ |
|
|
bors-servo
pushed a commit
that referenced
this pull request
Jul 23, 2015
Replace `i8` with `libc::c_char` It is definitely suboptimal to manually edit autogenerated code and surely incomplete but, at least, gets servo build on platforms where char is unsigned (e.g., on aarch64). It would be great if a future version of bindgen could generate `libc::c_char` at the right places. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/179) <!-- Reviewable:end -->
|
|
bors-servo
merged commit b5e8488
into
servo:master
1 check was pending
1 check was pending
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
akosthekiss commentedJul 22, 2015
It is definitely suboptimal to manually edit autogenerated code and
surely incomplete but, at least, gets servo build on platforms
where char is unsigned (e.g., on aarch64).
It would be great if a future version of bindgen could generate
libc::c_charat the right places.