Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace `i8` with `libc::c_char` #179

Merged
merged 1 commit into from Jul 23, 2015
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Replace `i8` with `libc::c_char`

It is definitely suboptimal to manually edit autogenerated code and
surely incomplete but, at least, gets servo build on platforms
where char is unsigned (e.g., on aarch64).

It would be great if a future version of bindgen could generate
`libc::c_char` at the right places.
  • Loading branch information
akosthekiss committed Jul 22, 2015
commit b5e8488c2fca05c2d074cc2583473d7d145b0bcc
@@ -193,7 +193,7 @@ extern "C" {
pub fn CreateWrapperProxyHandler(aTraps: *const ProxyTraps)
-> *const ::libc::c_void;
pub fn GetCrossCompartmentWrapper() -> *const ::libc::c_void;
pub fn NewCompileOptions(aCx: *mut JSContext, aFile: *const i8,
pub fn NewCompileOptions(aCx: *mut JSContext, aFile: *const ::libc::c_char,
aLine: u32) -> *mut ReadOnlyCompileOptions;
pub fn DeleteCompileOptions(aOpts: *mut ReadOnlyCompileOptions);
pub fn NewProxyObject(aCx: *mut JSContext,
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.