Fix signature of JS_BufferIsCompilableUnit

[tschneidereit]

r? @larsbergstrom

[Manishearth]

This is size_t. Should we be be using usize?

[tschneidereit]

This is size_t. Should we be be using usize?

Probably, yes. It seems like bindgen generated wrong code for size_t? I
wonder if that afflicts more sites than just this one.

[Manishearth]

cc @michaelwu

[Ms2ger]

Yes and yes: #185

[Manishearth]

Is libc::size_t different from usize? It would be nice to use Rust ints whenever possible.

[michaelwu]

https://gist.github.com/michaelwu/a9525f07112a8224a540 is the latest output from bindgen. size_t is handled correctly now.

Replacing size_t with usize sounds good - I'll try that next time, though I think we should stick to size_t for now for consistency.

[michaelwu]

This needs to be size_t.

[michaelwu]

Shouldn't work everywhere. Since this is using size_t, this particular symbol likely to be mangled in three different ways. One for 32bit systems, one for 64 bit Linux, and another for 64 bit OSX. This is why many functions that use size_t have three different versions, controlled by cfg attributes.

[michaelwu]

This should be fixed by the bindings update.

[michaelwu]

#198 will fix this.